linux-kernel - bpf.h drift due to bpf_sk_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 26 Oct 2017 10:56:28 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Wang Nan <wangnan0@...wei.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: bpf.h drift due to bpf_sk_redirect_map()

Hi John,

	Recently the tools/perf/ build system noticed drift in
tools/include/uapi/linux/bpf.h from its master copy
include/uapi/linux/bpf.h, which comes from changes from you, can you
please check this?

[acme@...et linux]$ diff -u tools/include/uapi/linux/bpf.h include/uapi/linux/bpf.h
--- tools/include/uapi/linux/bpf.h	2017-10-26 08:10:15.980323396 -0300
+++ include/uapi/linux/bpf.h	2017-10-19 14:26:13.859622885 -0300
@@ -569,10 +569,9 @@
  *     @flags: reserved for future use
  *     Return: 0 on success or negative error code
  *
- * int bpf_sk_redirect_map(skb, map, key, flags)
+ * int bpf_sk_redirect_map(map, key, flags)
  *     Redirect skb to a sock in map using key as a lookup key for the
  *     sock in map.
- *     @skb: pointer to skb
  *     @map: pointer to sockmap
  *     @key: key to lookup sock in map
  *     @flags: reserved for future use
[acme@...et linux]$

- Arnaldo