linux-kernel - Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171031084248.GA11479@kroah.com>
Date:   Tue, 31 Oct 2017 09:42:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Long Li <longli@...hange.microsoft.com>
Cc:     "K . Y . Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        Paul Meyer <Paul.Meyer@...rosoft.com>
Subject: Re: [PATCH] hv: kvp: Avoid reading past allocated blocks from KVP
 file

On Mon, Oct 30, 2017 at 05:08:03PM -0700, Long Li wrote:
> From: Paul Meyer <Paul.Meyer@...rosoft.com>
> 
> While reading in more than one block (50) of KVP records, the allocation goes
> per block, but the reads used the total number of allocated records (without
> resetting the pointer/stream). This causes the records buffer to overrun when
> the refresh reads more than one block over the previous capacity (e.g. reading
> more than 100 KVP records whereas the in-memory database was empty before).

Please wrap changelogs at 72 columns like your editor asked you to...

> 
> Fix this by reading the correct number of KVP records from file each time.
> 
> Signed-off-by: Paul Meyer <Paul.Meyer@...rosoft.com>
> ---

Why is your name not also on the signed-off-by chain if you are
forwarding on a patch from someone else?

Is this patch also needed on stable kernels?

thanks,

greg k-h