linux-kernel - Re: [PATCH AUTOSEL for 4.14 30/51] irqchip/gic: Make quirks matching conditional on init return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4248cdee-ebb0-98e3-a270-e3254a231d0a@arm.com>
Date:   Thu, 23 Nov 2017 08:50:03 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     alexander.levin@...izon.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH AUTOSEL for 4.14 30/51] irqchip/gic: Make quirks matching
 conditional on init return value

On 22/11/17 22:25, alexander.levin@...izon.com wrote:
> From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> 
> [ Upstream commit 9d111d49106b61f5a652d5418e85d8741b1a0427 ]
> 
> As it turns out, the IIDR is not sufficient to distinguish between GICv3
> implementations when it comes to enabling quirks. So update the prototype
> of the init() hook to return a bool, and interpret a 'false' return value
> as no match, in which case the 'enabling workaround' log message should
> not be printed.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>

What is the point of backporting this patch? It's only use is to enable
a workaround that is not a pre-4.15 candidate.

Same for its equivalent in the 4.9 tree.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...