linux-kernel - Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511427087.8489.4.camel@mtksdaap41>
Date:   Thu, 23 Nov 2017 16:51:27 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
CC:     <ulrich.hecht+renesas@...il.com>,
        <laurent.pinchart@...asonboard.com>, <p.zabel@...gutronix.de>,
        <airlied@...ux.ie>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <mturquette@...libre.com>, <sboyd@...eaurora.org>,
        <lee.jones@...aro.org>, <davem@...emloft.net>,
        <gregkh@...uxfoundation.org>, <mchehab@...nel.org>,
        <rdunlap@...radead.org>, <pi-cheng.chen@...aro.org>,
        <sean.wang@...iatek.com>, <linux-clk@...r.kernel.org>,
        <linux@...linux.org.uk>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH 6/8] drm/mediatek: Add mfd support for mt8173

Hi, Matthias:

On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote:
> Use the MFD device for SoC mt8173. Probing via devicetree
> is no longer needed for any SoC, so delete it.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>

Acked-by: CK Hu <ck.hu@...iatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 +++++++---------------------
>  1 file changed, 7 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 5a263aa3ab6e..1eb02acf229a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -409,20 +409,12 @@ static int mtk_drm_probe(struct platform_device *pdev)
>  	INIT_WORK(&private->commit.work, mtk_atomic_work);
>  	private->data = of_device_get_match_data(dev);
>  
> -	/* Check if called from mfd */
> -	if (!dev->of_node) {
> -		mmsys_private = dev_get_drvdata(pdev->dev.parent);
> -		private->data = (struct mtk_mmsys_driver_data *)
> -				platform_get_device_id(pdev)->driver_data;
> -		private->config_regs =
> -			syscon_node_to_regmap(mmsys_private->of_node);
> -		parent_node = mmsys_private->of_node->parent;
> -	} else {
> -		private->config_regs = syscon_node_to_regmap(dev->of_node);
> -		if (IS_ERR(private->config_regs))
> -			return PTR_ERR(private->config_regs);
> -		parent_node = dev->of_node->parent;
> -	}
> +	mmsys_private = dev_get_drvdata(pdev->dev.parent);
> +	private->data = (struct mtk_mmsys_driver_data *)
> +			platform_get_device_id(pdev)->driver_data;
> +	private->config_regs =
> +		syscon_node_to_regmap(mmsys_private->of_node);
> +	parent_node = mmsys_private->of_node->parent;
>  
>  	/* Iterate over sibling DISP function blocks */
>  	for_each_child_of_node(parent_node, node) {
> @@ -565,14 +557,9 @@ static int mtk_drm_sys_resume(struct device *dev)
>  static SIMPLE_DEV_PM_OPS(mtk_drm_pm_ops, mtk_drm_sys_suspend,
>  			 mtk_drm_sys_resume);
>  
> -static const struct of_device_id mtk_drm_of_ids[] = {
> -	{ .compatible = "mediatek,mt8173-mmsys",
> -	  .data = &mt8173_mmsys_driver_data},
> -	{ }
> -};
> -
>  static const struct platform_device_id mtk_drm_ids[] = {
>  	{ "drm-mt2701-mm", (kernel_ulong_t)&mt2701_mmsys_driver_data },
> +	{ "drm-mt8173-mm", (kernel_ulong_t)&mt8173_mmsys_driver_data },
>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(platform, mtk_drm_ids);
> @@ -582,7 +569,6 @@ static struct platform_driver mtk_drm_platform_driver = {
>  	.remove	= mtk_drm_remove,
>  	.driver	= {
>  		.name	= "mediatek-drm",
> -		.of_match_table = mtk_drm_of_ids,
>  		.pm     = &mtk_drm_pm_ops,
>  	},
>  	.id_table = mtk_drm_ids,