linux-kernel - Re: ASoC: da7218: Use common error handling code in da7218_of_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <badb0c28-818b-2c71-e4f2-088e6ca0fb6f@users.sourceforge.net>
Date:   Fri, 24 Nov 2017 13:50:21 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        support.opensource@...semi.com
Cc:     Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: ASoC: da7218: Use common error handling code in
 da7218_of_to_pdata()

>> Add a jump target so that a bit of exception handling can be better reused
>> in an if branch of this function.
…
> Hmm. Doesn't really gain an awful lot this.

I show just another small change possibility.


> Would understand if there were multiple return paths,
> but in that case I'd have implemented something like this anyway.

Where?

Can the suggested software refactoring become useful also for this
function implementation?


> Also your patch description isn't really correct.

Which wording would you find more appropriate?


> You're re-using code from the sunny day scenario to handle an exception.

Can this detail be better?

Regards,
Markus