lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 Nov 2017 13:50:21 +0100
From:   SF Markus Elfring <>
To:     Adam Thomson <>,
        "" <>,
Cc:     Jaroslav Kysela <>,
        Liam Girdwood <>,
        Mark Brown <>, Takashi Iwai <>,
        LKML <>,
Subject: Re: ASoC: da7218: Use common error handling code in

>> Add a jump target so that a bit of exception handling can be better reused
>> in an if branch of this function.
> Hmm. Doesn't really gain an awful lot this.

I show just another small change possibility.

> Would understand if there were multiple return paths,
> but in that case I'd have implemented something like this anyway.


Can the suggested software refactoring become useful also for this
function implementation?

> Also your patch description isn't really correct.

Which wording would you find more appropriate?

> You're re-using code from the sunny day scenario to handle an exception.

Can this detail be better?


Powered by blists - more mailing lists