lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 24 Nov 2017 12:55:58 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Support Opensource <Support.Opensource@...semi.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Liam Girdwood <lgirdwood@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/3] ASoC: da7218: Use common error handling code in
 da7218_of_to_pdata()

On Fri, Nov 24, 2017 at 12:03:32PM +0000, Adam Thomson wrote:
> On 23 November 2017 20:06, SF Markus Elfring wrote:

> > Add a jump target so that a bit of exception handling can be better reused
> > in an if branch of this function.

> Hmm. Doesn't really gain an awful lot this. Would understand if there were
> multiple return paths, but in that case I'd have implemented something like
> this anyway. Also your patch description isn't really correct. You're re-using
> code from the sunny day scenario to handle an exception.

Other people have given him similar feedback on his other patches with
this pattern.  I'm not intending to apply any of them.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists