linux-kernel - Re: [PATCH 3/4] ARM: pxa/spitz: Remove hardcoded partitioning, use sharpslpart parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Nov 2017 13:52:22 +0100
From:   Andrea Adami <andrea.adami@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Russell King <linux@...linux.org.uk>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] ARM: pxa/spitz: Remove hardcoded partitioning, use
 sharpslpart parser

On Thu, Nov 23, 2017 at 12:06 AM, Pavel Machek <pavel@....cz> wrote:
> On Tue 2017-11-21 22:43:50, Andrea Adami wrote:
>> With the introduction of sharpslpart partition parser we can now read the
>> offsets from NAND: we specify the list of the parsers as platform data, with
>> cmdlinepart and ofpart parsers first allowing to override the part. table
>> written in NAND. This is done here in the board file.
>>
>> Emulators like qemu will need to pass the mtdparts in the cmdline.
>
> IOW this will be regression for people emulating zaurus in qemu.
>
> ...
>
> Is it good idea? Its not like this platform data is particulary big or
> changes very often...

Hello Pavel,

afais defining the partitions in the board file is today deprecated,
more than this the definitions are not totally correct,
e.g. ignoring the differences between 3100 and 3200 models.

The original Zaurus kernels did specify mtdparts= in the cmdline so I
don't see this being a big limitation for QEMU.

We are trying to clean out the board files and hopefully move the pxa
Zaurus to devicetree one day...
I think that removing the parttioning differences will ease the task.
Please correct me if I am wrong.

Cheers
Andrea


>
>> Signed-off-by: Andrea Adami <andrea.adami@...il.com>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html