linux-kernel - Re: [PATCH v2] KVM: X86: Fix load bad host fpu state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Dec 2017 20:01:41 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm <kvm@...r.kernel.org>, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>,
        Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH v2] KVM: X86: Fix load bad host fpu state

2017-12-13 17:59 GMT+08:00 David Hildenbrand <david@...hat.com>:
>
>>       if (unlikely(vcpu->arch.mp_state == KVM_MP_STATE_UNINITIALIZED)) {
>> @@ -7709,6 +7706,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
>>  static void fx_init(struct kvm_vcpu *vcpu)
>>  {
>>       fpstate_init(&vcpu->arch.guest_fpu.state);
>> +     fpstate_init(&vcpu->arch.user_fpu.state);
>
> Won't at least one of them trigger the WARN in fpstate_init?

Nothing trigger the WARN during my testing on a Skylake box. And I
will not continue to push this one since there is an alternative
solution in kvm/queue.

Regards,
Wanpeng Li