lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20171215115122.ckxgoqzlliufz7cm@localhost.localdomain> Date: Fri, 15 Dec 2017 11:51:22 +0000 From: Charles Keepax <ckeepax@...nsource.cirrus.com> To: Mark Brown <broonie@...nel.org> CC: Olivier Moysan <olivier.moysan@...com>, <lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.com>, <mcoquelin.stm32@...il.com>, <alexandre.torgue@...com>, <alsa-devel@...a-project.org>, <linux-arm-kernel@...ts.infradead.org>, <kernel@...inux.com>, <linux-kernel@...r.kernel.org>, <arnaud.pouliquen@...com>, <benjamin.gaignard@...com>, <patches@...nsource.wolfsonmicro.com> Subject: Re: [RFC PATCH 1/2] ASoC: add support of mclk clock providers in wm8894 driver On Thu, Dec 14, 2017 at 05:30:25PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 05:53:57PM +0100, Olivier Moysan wrote: > > > + pdata->mclk1 = devm_clk_get(wm8994->dev, "MCLK1"); > > + if (IS_ERR(pdata->mclk1)) > > + pdata->mclk1 = NULL; > > These should special case -EPROBE_DEFER so we defer properly if we need > to (and ideally log an error in case there was a MCLK and we legit ran > into an error). We probably want the special case on there being no clock at all which should silently proceed as this code does and then actual errors and PROBE_DEFERs can log and fail. Thanks, Charles
Powered by blists - more mailing lists