linux-kernel - Re: [PATCH] ALSA: aloop: Mark paused device as inactive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htvt283bs.wl-tiwai@suse.de>
Date:   Tue, 27 Mar 2018 08:01:11 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Robert Rosengren <robert.rosengren@...s.com>
Cc:     <alsa-devel@...a-project.org>, Jaroslav Kysela <perex@...ex.cz>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: aloop: Mark paused device as inactive

On Tue, 27 Mar 2018 07:41:44 +0200,
Robert Rosengren wrote:
> 
> On 03/26/2018 04:43 PM, Takashi Iwai wrote:
> > On Mon, 26 Mar 2018 07:24:49 +0200,
> > Robert Rosengren wrote:
> >>
> >> Show paused ALSA aloop device as inactive, i.e. the control
> >> "PCM Slave Active" set as false. Notification sent upon state change.
> >>
> >> This makes it possible for client capturing from aloop device to know if
> >> data is expected. Without it the client expects data even if playback
> >> is paused.
> >>
> >> Signed-off-by: Robert Rosengren <robertr@...s.com>
> > 
> > The code change looks good, but just to be sure:
> > you've submitted from the address robert.rosengren@...s.com that is
> > different from the sign-off robertr@...s.com.  Is this intentional?
> > The former is recorded as the author in git history.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> 
> Sorry for the confusion. It is not intentional to use different though both are valid, apparently I have used the longer one in earlier patches to kernel so please change:
> Signed-off-by: Robert Rosengren <robert.rosengren@...s.com>

OK, applied now.  Thanks.


Takashi