linux-kernel - Re: [PATCH 3/7] x86,tlb: change tlbstate.is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1529687307.7898.197.camel@surriel.com>
Date:   Fri, 22 Jun 2018 13:08:27 -0400
From:   Rik van Riel <riel@...riel.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     x86@...nel.org, luto@...nel.org, mingo@...nel.org,
        tglx@...utronix.de, efault@....de, songliubraving@...com,
        kernel-team@...com
Subject: Re: [PATCH 3/7] x86,tlb: change tlbstate.is_lazy to tlbstate.state

On Fri, 2018-06-22 at 10:01 -0700, Dave Hansen wrote:
> On 06/20/2018 12:56 PM, Rik van Riel wrote:
> > +#define TLBSTATE_OK	0
> > +#define TLBSTATE_LAZY	1
> 
> Could we spell out a bit more about what "OK" means in comments?  It
> obviously means "not lazy", but anything else?

After discussion with Andy, I plan to simply drop
this patch, and use memory ordering between updating
tlbstate.is_lazy and *.tlb_gen to take care of getting
the TLB reloaded at context switch time if needed.

We should not need the extra TLBSTATE_FLUSH state,
so a boolean is fine and this patch is unnecessary.

-- 
All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)