linux-kernel - Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180710175940.rbjmdcpm54gfrael@pburton-laptop>
Date:   Tue, 10 Jul 2018 10:59:40 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     Serge Semin <fancer.lancer@...il.com>
Cc:     Mathieu Malaterre <malat@...ian.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <jhogan@...nel.org>, okaya@...eaurora.org,
        chenhc@...ote.com, Sergey.Semin@...latforms.ru,
        Linux-MIPS <linux-mips@...ux-mips.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "# v4 . 11" <stable@...r.kernel.org>
Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated()
 method

Hi Sergey,

On Tue, Jul 10, 2018 at 10:48:15AM +0300, Serge Semin wrote:
> On Tue, Jul 10, 2018 at 09:15:17AM +0200, Mathieu Malaterre <malat@...ian.org> wrote:
> > On Mon, Jul 9, 2018 at 3:57 PM Serge Semin <fancer.lancer@...il.com> wrote:
> > > Adaptive ioremap_wc() method is now available (see "mips: mm:
> > > Create UCA-based ioremap_wc() method" commit). We can use it for
> > > UCA-featured MMIO transactions in the kernel, so we don't need
> > > it platform clone ioremap_uncached_accelerated() being declard.
> > > Seeing it is also unused anywhere in the kernel code, lets remove
> > > it from io.h arch-specific header then.
> > >
> > > Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> > > Singed-off-by: Paul Burton <paul.burton@...s.com>
> > 
> > nit: 'Signed' (on both patches)
> 
> Good catch! Thanks. Didn't notice the typo. Should have copy-pasted
> both the signature and the e-mail from another letter.
> 
> I'll fix it if there will be a second version of the patchset. Otherwise
> I suppose it would be easier for the integrator to do this.

I've fixed this up & applied these 2 patches with minor tweaks to
mips-next for 4.19.

However FYI for next time - you shouldn't really add someone else's
Signed-off-by tag anyway. The tag effectively states that a person can
agree to the Developer's Certificate of Origin for this patch (see
Documentation/process/submitting-patches.rst), and you can't agree that
on behalf of someone else. Generally a maintainer should add this tag
for themselves when they apply a patch.

Anyway, I think we should reserve the Singed-off-by tag for patches that
quell fires. ;)

Thanks,
    Paul