linux-kernel - Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F5C1808B-516D-4D74-BC43-6E997D9F012A@goldelico.com>
Date:   Wed, 25 Jul 2018 10:30:45 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Arnd Bergmann <arnd@...db.de>, "Reizer, Eyal" <eyalr@...com>,
        Kees Cook <keescook@...omium.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings


> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@...eaurora.org>:
> 
> "H. Nikolaus Schaller" <hns@...delico.com> writes:
> 
>> wl1271_warning() already appends a \n to the format,
>> so adding one to the warning string gives empty lines in the log.
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> 
> "drivers: net:" in the title is unnecessary, but I can remove that.

Ok, thanks! I wasn't aware of the precise subsystem tagging style here.

BR,
Nikolaus