linux-kernel - Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87lg9zvhc1.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 25 Jul 2018 11:40:30 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Arnd Bergmann <arnd@...db.de>, "Reizer\, Eyal" <eyalr@...com>,
        Kees Cook <keescook@...omium.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com
Subject: Re: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings

"H. Nikolaus Schaller" <hns@...delico.com> writes:

>> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@...eaurora.org>:
>> 
>> "H. Nikolaus Schaller" <hns@...delico.com> writes:
>> 
>>> wl1271_warning() already appends a \n to the format,
>>> so adding one to the warning string gives empty lines in the log.
>>> 
>>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>> 
>> "drivers: net:" in the title is unnecessary, but I can remove that.
>
> Ok, thanks! I wasn't aware of the precise subsystem tagging style here.

Yeah, subsystems can do it a bit differently. But you can easily check
with git log the preferred style:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

-- 
Kalle Valo