linux-kernel - RE: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB421178C5283BDCCF11F5E2AF802B0@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Thu, 26 Jul 2018 11:00:27 +0000
From:   "A.s. Dong" <aisheng.dong@....com>
To:     Jassi Brar <jassisinghbrar@...il.com>,
        Oleksij Rempel <o.rempel@...gutronix.de>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Devicetree List <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ", Sascha Hauer" <kernel@...gutronix.de>,
        ", linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, srv_heupstream" 
        <linux-arm-kernel@...ts.infradead.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal
 to 0

> -----Original Message-----
> From: Jassi Brar [mailto:jassisinghbrar@...il.com]
> Sent: Thursday, July 26, 2018 5:42 PM
> To: Oleksij Rempel <o.rempel@...gutronix.de>
> Cc: Shawn Guo <shawnguo@...nel.org>; Fabio Estevam
> <fabio.estevam@....com>; Rob Herring <robh+dt@...nel.org>; Mark
> Rutland <mark.rutland@....com>; A.s. Dong <aisheng.dong@....com>;
> Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>; Sudeep Holla
> <sudeep.holla@....com>; Devicetree List <devicetree@...r.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; , Sascha Hauer
> <kernel@...gutronix.de>; , linux-arm-kernel@...ts.infradead.org, linux-
> mediatek@...ts.infradead.org, srv_heupstream <linux-arm-
> kernel@...ts.infradead.org>; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be
> equal to 0
> 
> On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel <o.rempel@...gutronix.de>
> wrote:
> > From: Dong Aisheng <aisheng.dong@....com>
> >
> > Mailbox devices may have only one channel which means the mbox-cells
> > at least 1 does not make sense for this type devices. Let's remove
> > that limitation to allow the mbox-cells to be equal to 0.
> >
> OK
> 
> But please realise that you'll have to write more code -- implement your own
> of_xlate() callback.
> Most developers would prefer to call the only channel as channel number 0,
> and use the common of_xlate implementation.
> 

Yes, that's true because the common of_xlate assuming the mbox-cells is 1.
And there's already such users:
arch/arm/boot/dts/bcm283x.dtsi

More comments will be on your reply of patch-3.

Regards
Dong Aisheng

> -jassi