linux-kernel - Re: [PATCH v2] cpu/hotplug: Fix cpuhp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cf38a28-e95e-a8e4-9e1f-a83a6973436a@codeaurora.org>
Date:   Thu, 26 Jul 2018 17:22:58 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        Brendan Jackman <brendan.jackman@....com>,
        Mathieu Malaterre <malat@...ian.org>
Cc:     gkohli@...eaurora.org, neeraju@...eaurora.org
Subject: Re: [PATCH v2] cpu/hotplug: Fix cpuhp_step name for timers

Hi All,

Can i get input on this ?

Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
> After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
> on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
> instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
> for timer looks to be invalid. So, better to name it as
> "timers:prepare".
>
> Signed-off-by: Mukesh Ojha <mojha@...eaurora.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Lai Jiangshan <jiangshanlai@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Brendan Jackman <brendan.jackman@....com>
> Cc: Mathieu Malaterre <malat@...ian.org>
> ---
> Changes in v2:
>   - Updated commit text.
>
>   kernel/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 0db8938..8e6606a 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)
>   	 * otherwise a RCU stall occurs.
>   	 */
>   	[CPUHP_TIMERS_PREPARE] = {
> -		.name			= "timers:dead",
> +		.name			= "timers:prepare",
>   		.startup.single		= timers_prepare_cpu,
>   		.teardown.single	= timers_dead_cpu,
>   	},