lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 8 Aug 2018 14:22:37 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Leonardo Brás <leobras.c@...il.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/15] staging: fbtft: Includes description to mutex
 and spinlock - Style

On Tue, Aug 07, 2018 at 09:29:31PM -0300, Leonardo Brás wrote:
>  Includes description to mutex and spinlocks, as recommended by checkpatch.pl.
> 
> Signed-off-by: Leonardo Brás <leobras.c@...il.com>
> ---
>  drivers/staging/fbtft/fbtft.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 6ee9ff320567..f771271d497a 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -203,7 +203,7 @@ struct fbtft_par {
>  	u8 *buf;
>  	u8 startbyte;
>  	struct fbtft_ops fbtftops;
> -	spinlock_t dirty_lock;
> +	spinlock_t dirty_lock; /*Protects dirty_lines_{start,end}*/

Why no spaces in your comment?

thanks,

greg k-h

Powered by blists - more mailing lists