lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 8 Aug 2018 14:24:28 +0200
From:   Greg Kroah-Hartman <>
To:     Leonardo Brás <>
Cc:     Thomas Petazzoni <>,,
Subject: Re: [PATCH v2 15/15] staging: fbtft: Replaces custom debug macro
 with dev_dbg().

On Tue, Aug 07, 2018 at 09:30:10PM -0300, Leonardo Brás wrote:
> Changes custom macro to dev_dbg to avoid parameter multiple usage and use of typeof().

linewrap please.

And while this is a good start, please replace the places this custom
macro is called with dev_dbg(), and then delete this macro.  Don't
extend its life with a change like this :(


greg k-h

Powered by blists - more mailing lists