linux-kernel - Re: [PATCH] leds: Convert to using %pOFn instead of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e5ea614-5242-eabc-2e4a-aa20432a4a12@gmail.com>
Date:   Tue, 28 Aug 2018 22:37:03 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Sakari Ailus <sakari.ailus@....fi>, Pavel Machek <pavel@....cz>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: Convert to using %pOFn instead of device_node.name

Hi Rob,

Thank you for the patch.

On 08/28/2018 03:52 AM, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
> 
> Cc: Sakari Ailus <sakari.ailus@....fi>
> Cc: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: linux-leds@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/leds/leds-as3645a.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index f883616d9e60..98a69b1a43f9 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -529,7 +529,7 @@ static int as3645a_parse_node(struct as3645a *flash,
>  		strlcpy(names->flash, name, sizeof(names->flash));
>  	else
>  		snprintf(names->flash, sizeof(names->flash),
> -			 "%s:flash", node->name);
> +			 "%pOFn:flash", node);
>  
>  	rval = of_property_read_u32(flash->flash_node, "flash-timeout-us",
>  				    &cfg->flash_timeout_us);
> @@ -573,7 +573,7 @@ static int as3645a_parse_node(struct as3645a *flash,
>  		strlcpy(names->indicator, name, sizeof(names->indicator));
>  	else
>  		snprintf(names->indicator, sizeof(names->indicator),
> -			 "%s:indicator", node->name);
> +			 "%pOFn:indicator", node);
>  
>  	rval = of_property_read_u32(flash->indicator_node, "led-max-microamp",
>  				    &cfg->indicator_max_ua);
> 

Applied.

-- 
Best regards,
Jacek Anaszewski