lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2018 15:12:05 +0200 From: David Hildenbrand <david@...hat.com> To: Pasha Tatashin <Pavel.Tatashin@...rosoft.com>, "linux-mm@...ck.org" <linux-mm@...ck.org> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, Rashmica Gupta <rashmica.g@...il.com>, Michael Neuling <mikey@...ling.org>, Balbir Singh <bsingharora@...il.com>, Nathan Fontenot <nfont@...ux.vnet.ibm.com>, John Allen <jallen@...ux.vnet.ibm.com>, Andrew Morton <akpm@...ux-foundation.org>, Michal Hocko <mhocko@...e.com>, Dan Williams <dan.j.williams@...el.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, Vlastimil Babka <vbabka@...e.cz>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Oscar Salvador <osalvador@...e.de>, YASUAKI ISHIMATSU <yasu.isimatu@...il.com>, Mathieu Malaterre <malat@...ian.org> Subject: Re: [PATCH RFCv2 1/6] mm/memory_hotplug: make remove_memory() take the device_hotplug_lock On 30.08.2018 21:35, Pasha Tatashin wrote: >> + >> +void __ref remove_memory(int nid, u64 start, u64 size) > > Remove __ref, otherwise looks good: Indeed, will do. Thanks for the review. Will resend in two weeks when I'm back from vacation. Cheers! > > Reviewed-by: Pavel Tatashin <pavel.tatashin@...rosoft.com> > >> +{ >> + lock_device_hotplug(); >> + __remove_memory(nid, start, size); >> + unlock_device_hotplug(); >> +} >> EXPORT_SYMBOL_GPL(remove_memory); >> #endif /* CONFIG_MEMORY_HOTREMOVE */ -- Thanks, David / dhildenb
Powered by blists - more mailing lists