linux-kernel - Re: [PATCH 38/48] perf record: Read record thread's mmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180923193522.GF30923@krava>
Date:   Sun, 23 Sep 2018 21:35:22 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andi Kleen <andi@...stfloor.org>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        kernel-team@....com
Subject: Re: [PATCH 38/48] perf record: Read record thread's mmaps

On Mon, Sep 17, 2018 at 08:28:37PM +0900, Namhyung Kim wrote:

SNIP

> > -
> > -		if (track_map && track_map->base) {
> > -			if (perf_mmap__push(track_map, rec, record__pushfn) != 0) {
> > -				rc = -1;
> > -				goto out;
> > -			}
> > -		}
> >  	}
> >  
> >  	/*
> >  	 * Mark the round finished in case we wrote
> >  	 * at least one event.
> >  	 */
> > -	if (bytes_written != rec->bytes_written)
> > -		rc = record__write(rec, NULL, &finished_round_event, sizeof(finished_round_event));
> > +	if (bytes_written != rec->bytes_written) {
> > +		/*
> > +		 * All maps of the threads point to a single file,
> > +		 * so we can just pick first one.
> > +		 */
> > +		rc = record__write(rec, thread->mmap[0], &finished_round_event,
> 
> Shouldn't it be maps[0] ?

yep, overwrite wouldn't work..

thanks,
jirka