linux-kernel - Re: [PATCH v11 3/3]: perf record: extend trace writing to multi AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e999d83f-5a2d-6e59-bc46-25b3516ed425@linux.intel.com>
Date:   Mon, 8 Oct 2018 18:21:48 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 3/3]: perf record: extend trace writing to multi AIO

Hi,

On 08.10.2018 15:45, Jiri Olsa wrote:
<SNIP>
> 
> 'perf record --aio-cblocks=N' could imply '--aio',
> 
> I'd like to have simple/intuitive way to enable that,
> without studing the meaning of the cblocks argument
> 
>   # perf record --aio ...
> 
> means that I'm storing data via async writes,
> and using some reasonable default for cblocks

Semantically, --aio is equal to --aio-cblocks=default, as you said.
So, options duplication could be avoided by having some parsing 
callback using OPT_CALLBACK().

> 
> and later on we'd add 'perf record --threads'
> allowing threads based writers ;-)

Oh, I see. Cool.

Thanks,
Alexey

> 
> jirka
>