linux-kernel - Re: [PATCH 2/4] gpio: Drop parent irq assignment during cascade setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Oct 2018 09:28:50 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        evgreen@...omium.org, Thierry Reding <treding@...dia.com>,
        Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH 2/4] gpio: Drop parent irq assignment during cascade setup

On Mon, Oct 8, 2018 at 6:32 PM Stephen Boyd <swboyd@...omium.org> wrote:

> We want to set the irq parent for interrupts that we're setting up to be
> cascaded from another interrupt controller, but we may or may not have
> already mapped the gpiochip irqs into the kernel's virtual irq number
> space at this point. If we have mapped irqs before calling here, then
> we've gone through gpiochip_irq_map() and called irq_set_parent()
> already. If we haven't mapped irqs, then the gpiochip is dynamically
> mapping irqs and we can rely on gpiochip_irq_map() or the gpio driver's
> irqdomain ops to setup the irq parent properly.
>
> Either way, setting the parent here when cascading the gpiochip doesn't
> make much sense because it should be done at irq mapping time. In the
> dynamic mapping case, this code is mapping virq 0 to some parent virq in
> a loop. While that's benign, let's drop this code to simplify.
>
> Cc: Evan Green <evgreen@...omium.org>
> Cc: Thierry Reding <treding@...dia.com>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>

Yep this is some leftover from the past.

Patch applied!

Yours,
Linus Walleij