lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 24 Oct 2018 11:59:34 +0300 (EEST)
From:   Jarkko Sakkinen <>
To:     "Winkler, Tomas" <>
cc:     Jarkko Sakkinen <>,
        Jason Gunthorpe <>,
        Nayna Jain <>,
        "Usyskin, Alexander" <>,
        "Struk, Tadeusz" <>,
        "" <>,
        "" <>,
        "" <>
Subject: RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.

On Tue, 23 Oct 2018, Winkler, Tomas wrote:
> To  the  out  label we jump after we are  done with locality and cmd
> read() before we jump to locality 'locality'.  We will need to add
> another variable to check If cmd_ready() was called or not in order to
> get rid of the extran label, it's not internally tracked so far.

I think this is fine.

Reviewed-by: Jarkko Sakkinen <>
Tested-by: Jarkko Sakkinen <>

I tested this by assigning rc error code instead of requesting locality
in addition of testig unchanged code.


Powered by blists - more mailing lists