linux-kernel - Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e5fd8bc-0b18-ea88-ed95-ec81a44d0783@intel.com>
Date:   Fri, 26 Oct 2018 12:59:55 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        x86@...nel.org, peterz@...radead.org, mpe@...erman.id.au,
        will.deacon@....com, luto@...nel.org, jroedel@...e.de,
        danielmicay@...il.com
Subject: Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

On 10/26/18 12:51 PM, Dave Hansen wrote:
...
> The result is that, after a fork(), the child's pkey state ends up
> looking like it does after an execve(), which is totally wrong.  pkeys
> that are already allocated can be allocated again, for instance.

One thing I omitted.  This was very nicely discovered and reported by
danielmicay@...il.com.  Thanks, Daniel!