linux-kernel - Re: [PATCH] mm/gup: finish consolidating error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181121144404.efdab6dbccd7780034a55e1d@linux-foundation.org>
Date:   Wed, 21 Nov 2018 14:44:04 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     john.hubbard@...il.com
Cc:     linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>,
        John Hubbard <jhubbard@...dia.com>,
        Dan Williams <dan.j.williams@...el.com>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>
Subject: Re: [PATCH] mm/gup: finish consolidating error handling

On Wed, 21 Nov 2018 00:14:02 -0800 john.hubbard@...il.com wrote:

> Commit df06b37ffe5a4 ("mm/gup: cache dev_pagemap while pinning pages")
> attempted to operate on each page that get_user_pages had retrieved. In
> order to do that, it created a common exit point from the routine.
> However, one case was missed, which this patch fixes up.
> 
> Also, there was still an unnecessary shadow declaration (with a
> different type) of the "ret" variable, which this patch removes.
> 

What is the bug which this supposedly fixes and what is that bug's
user-visible impact?