linux-kernel - Re: [PATCH 19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9022b4f-35c9-4a7d-68e6-c942a538da02@embeddedor.com>
Date:   Wed, 19 Dec 2018 16:26:56 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Intel SCU Linux support <intel-linux-scu@...el.com>,
        Artur Paszkiewicz <artur.paszkiewicz@...el.com>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/41] scsi: isci: remote_node_context: mark expected
 switch fall-throughs

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
-- 
Gustavo

On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that, in this particular case, a dash is added as a token in
> order to separate the "Fall through" annotations from the rest of
> the comment on the same line, which is what GCC is expecting to find.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>   drivers/scsi/isci/remote_node_context.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/isci/remote_node_context.c b/drivers/scsi/isci/remote_node_context.c
> index e3f2a5359d71..474a43460963 100644
> --- a/drivers/scsi/isci/remote_node_context.c
> +++ b/drivers/scsi/isci/remote_node_context.c
> @@ -601,9 +601,9 @@ enum sci_status sci_remote_node_context_suspend(
>   				 __func__, sci_rnc);
>   			return SCI_FAILURE_INVALID_STATE;
>   		}
> -		/* Fall through and handle like SCI_RNC_POSTING */
> +		/* Fall through - and handle like SCI_RNC_POSTING */
>   	case SCI_RNC_RESUMING:
> -		/* Fall through and handle like SCI_RNC_POSTING */
> +		/* Fall through - and handle like SCI_RNC_POSTING */
>   	case SCI_RNC_POSTING:
>   		/* Set the destination state to AWAIT - this signals the
>   		 * entry into the SCI_RNC_READY state that a suspension
>