[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ff237a7e-0e0c-94e4-c977-134d071c9061@embeddedor.com>
Date: Wed, 19 Dec 2018 16:27:19 -0600
From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To: James Smart <james.smart@...adcom.com>,
Dick Kennedy <dick.kennedy@...adcom.com>
Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 22/41] scsi: lpfc: lpfc_ct: Mark expected switch
fall-throughs
Hi,
Friendly ping:
Who can ack or review this patch, please?
Thanks
--
Gustavo
On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 6305ffeba7ea..b2b7fcc23654 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -3050,6 +3050,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
> case SLI_MGMT_GHAT:
> case SLI_MGMT_GRPL:
> rsp_size = FC_MAX_NS_RSP;
> + /* fall through */
> case SLI_MGMT_DHBA:
> case SLI_MGMT_DHAT:
> pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
> @@ -3062,6 +3063,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
> case SLI_MGMT_GPAT:
> case SLI_MGMT_GPAS:
> rsp_size = FC_MAX_NS_RSP;
> + /* fall through */
> case SLI_MGMT_DPRT:
> case SLI_MGMT_DPA:
> pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
>
Powered by blists - more mailing lists