linux-kernel - Re: [PATCH 2/5] sched: convert signal_struct.sigcnt to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190121172822.GB8088@redhat.com>
Date:   Mon, 21 Jan 2019 18:28:23 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Elena Reshetova <elena.reshetova@...el.com>
Cc:     mingo@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        viro@...iv.linux.org.uk, akpm@...ux-foundation.org,
        keescook@...omium.org, tglx@...utronix.de
Subject: Re: [PATCH 2/5] sched: convert signal_struct.sigcnt to refcount_t

On 01/18, Elena Reshetova wrote:
>
> For the signal_struct.sigcnt it might make a difference
> in following places:
>  - put_signal_struct(): decrement in refcount_dec_and_test() only
>    provides RELEASE ordering and control dependency on success
>    vs. fully ordered atomic counterpart

this is fine.

Reviewed-by: Oleg Nesterov <oleg@...hat.com>