linux-kernel - Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Jan 2019 20:08:02 +0800
From:   Tianyu Lan <lantianyu1986@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Lan Tianyu <Tianyu.Lan@...rosoft.com>,
        Joerg Roedel <joro@...tes.org>, mchehab+samsung@...nel.org,
        davem@...emloft.net, akpm@...ux-foundation.org,
        nicolas.ferre@...rochip.com, Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r kernel org" <linux-kernel@...r.kernel.org>,
        iommu@...ts.linux-foundation.org, michael.h.kelley@...rosoft.com,
        kys@...rosoft.com, vkuznets@...hat.com,
        Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH 2/3] HYPERV/IOMMU: Add Hyper-V stub IOMMU driver

On Thu, Jan 31, 2019 at 7:59 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Jan 31, 2019 at 06:17:32PM +0800, lantianyu1986@...il.com wrote:
> > --- /dev/null
> > +++ b/drivers/iommu/hyperv-iommu.c
> > @@ -0,0 +1,189 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +#define pr_fmt(fmt)     "HYPERV-IR: " fmt
>
> Minor nit, you never do any pr_*() calls, so this isn't needed, right?

Yes, you are right. I will remove it. Sorry. I used pr_info() during
development stage and removed
them before sending patch out. Thanks.

>
> > +static cpumask_t ioapic_max_cpumask = { CPU_BITS_NONE };
> > +struct irq_domain *ioapic_ir_domain;
>
> Global?  Why?

It should be "static" here.

-- 
Best regards
Tianyu Lan