linux-kernel - Re: [PATCH v4 02/16] block: sed-opal: use correct macro for method length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1549666612.10972.50.camel@intel.com>
Date:   Fri, 8 Feb 2019 22:56:53 +0000
From:   "Derrick, Jonathan" <jonathan.derrick@...el.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zub@...ux.fjfi.cvut.cz" <zub@...ux.fjfi.cvut.cz>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "sbauer@...donthack.me" <sbauer@...donthack.me>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "jonas.rabenstein@...dium.uni-erlangen.de" 
        <jonas.rabenstein@...dium.uni-erlangen.de>
Subject: Re: [PATCH v4 02/16] block: sed-opal: use correct macro for method
 length

Looks good

Reviewed-by: Jon Derrick <jonathan.derrick@...el.com>

On Fri, 2019-02-01 at 21:50 +0100, David Kozub wrote:
> From: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> 
> Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same,
> it is weird to use OPAL_UID_LENGTH for the definition of the methods.
> 
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@...dium.uni-erlangen.de>
> Reviewed-by: Scott Bauer <sbauer@...donthack.me>
> ---
>  block/sed-opal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index c882a193e162..5c123a5b4ab1 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -181,7 +181,7 @@ static const u8 opaluid[][OPAL_UID_LENGTH] = {
>   * Derived from: TCG_Storage_Architecture_Core_Spec_v2.01_r1.00
>   * Section: 6.3 Assigned UIDs
>   */
> -static const u8 opalmethod[][OPAL_UID_LENGTH] = {
> +static const u8 opalmethod[][OPAL_METHOD_LENGTH] = {
>  	[OPAL_PROPERTIES] =
>  		{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x01 },
>  	[OPAL_STARTSESSION] =
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (3278 bytes)