linux-kernel - Re: [PATCH v7 15/22] parisc: define syscall_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1abba4b1-82ef-c23c-c59e-5562dcb5b1bb@gmx.de>
Date:   Thu, 28 Feb 2019 22:39:35 +0100
From:   Helge Deller <deller@....de>
To:     "Dmitry V. Levin" <ldv@...linux.org>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        linux-parisc@...r.kernel.org
Cc:     Elvira Khabirova <lineprinter@...linux.org>,
        Eugene Syromyatnikov <esyr@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Andy Lutomirski <luto@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 15/22] parisc: define syscall_get_error()

On 28.02.19 20:38, Dmitry V. Levin wrote:
> syscall_get_error() is required to be implemented on all
> architectures in addition to already implemented syscall_get_nr(),
> syscall_get_arguments(), syscall_get_return_value(), and
> syscall_get_arch() functions in order to extend the generic
> ptrace API with PTRACE_GET_SYSCALL_INFO request.
> 
> Cc: Helge Deller <deller@....de>
> Cc: James E.J. Bottomley <jejb@...isc-linux.org>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Elvira Khabirova <lineprinter@...linux.org>
> Cc: Eugene Syromyatnikov <esyr@...hat.com>
> Cc: linux-parisc@...r.kernel.org
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>

Acked-by: Helge Deller <deller@....de> # parisc

Helge


> ---
> 
> This is just a gentle ping, the patch is unchanged.
> 
> Notes:
>     v7: unchanged
>     v6: unchanged
>     v5: initial revision
> 
>  arch/parisc/include/asm/syscall.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/parisc/include/asm/syscall.h b/arch/parisc/include/asm/syscall.h
> index 8bff1a58c97f..477511ff7546 100644
> --- a/arch/parisc/include/asm/syscall.h
> +++ b/arch/parisc/include/asm/syscall.h
> @@ -43,6 +43,13 @@ static inline void syscall_get_arguments(struct task_struct *tsk,
>  	}
>  }
>  
> +static inline long syscall_get_error(struct task_struct *task,
> +				     struct pt_regs *regs)
> +{
> +	unsigned long error = regs->gr[28];
> +	return IS_ERR_VALUE(error) ? error : 0;
> +}
> +
>  static inline long syscall_get_return_value(struct task_struct *task,
>  						struct pt_regs *regs)
>  {
>