linux-kernel - Re: [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190228214121.GD30188@ravnborg.org>
Date:   Thu, 28 Feb 2019 22:41:21 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Claudiu.Beznea@...rochip.com
Cc:     lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        Ludovic.Desroches@...rochip.com, bbrezillon@...nel.org,
        airlied@...ux.ie, daniel@...ll.ch, thierry.reding@...il.com,
        devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/7] drm: atmel-hlcdc: avoid initializing cfg with zero

On Wed, Feb 27, 2019 at 04:24:21PM +0000, Claudiu.Beznea@...rochip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@...rochip.com>
> 
> Remove cfg initialization with zero and read state with
> drm_crtc_state_to_atmel_hlcdc_crtc_state() so that cfg to be initialized
> with state's output_mode.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
Looks good, good to have simpler code.
Reviewed-by: Sam Ravnborg <sam@...nborg.org>