linux-kernel - Re: [PATCH v4 0/9] Introduce STMFX I2C Multi-Function eXpander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aefde9a4-2775-6c36-7c75-b60f39434a53@st.com>
Date:   Thu, 28 Feb 2019 09:51:59 +0100
From:   Alexandre Torgue <alexandre.torgue@...com>
To:     Amelie Delaunay <amelie.delaunay@...com>,
        Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
CC:     <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH v4 0/9] Introduce STMFX I2C Multi-Function eXpander

Hi Amélie

On 2/27/19 10:34 AM, Amelie Delaunay wrote:
> This series adds support for STMicroelectronics Multi-Function eXpander
> (STMFX), used on some STM32 discovery and evaluation boards.
> 
> STMFX is an STM32L152 slave controller whose firmware embeds the following
> features:
> - I/O expander (16 GPIOs + 8 extra if the other features are not enabled),
> - resistive touchscreen controller,
> - IDD measurement.
> 
> I2C stuff and chip initialization is based on an MFD parent driver, which
> registers STMFX features MFD children.
> 
> ---
> Changes in v4:
> - mfd: move registers #define into the header
> - mfd: merge stmfx and stmfx_ddata structures into one stmfx structure
> - mfd: change stmfx_chip_init/exit and stmfx_irq_init/exit args: use
>    i2c_client struct and i2c_get_clientdata
> - mfd: fix typos
> - mfd: add MFD cells for IDD and TS features
> - pinctrl: rework registers #define
> - dts: add STMFX support on stm32mp157c-ev1
> Changes in v3:
> - fix MFD interrupt bindings
> - fix drivers/mfd/stmfx.c:103:8: warning: 'mask' may be used uninitialized
>    in this function
> Changes in v2:
> - move to MFD parent driver for i2c stuff and chip initialization
> - improve regmap configuration
> - take advantage of the use of gpio-ranges
> 
> Amelie Delaunay (9):
>    dt-bindings: mfd: Add ST Multi-Function eXpander (STMFX) core bindings
>    mfd: Add ST Multi-Function eXpander (STMFX) core driver
>    dt-bindings: pinctrl: document the STMFX pinctrl bindings
>    pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver
>    ARM: dts: stm32: add STMFX support on stm32746g-eval
>    ARM: dts: stm32: add joystick support on stm32746g-eval
>    ARM: dts: stm32: add orange and blue leds on stm32746g-eval
>    ARM: dts: stm32: add STMFX support on stm32mp157c-ev1
>    ARM: dts: stm32: add joystick support on stm32mp157c-ev1
> 

DT patches looks good. I'll take them in STM32 soc tree as soon as Lee 
takes driver part.

Regards
Alex