linux-kernel - Re: [PATCH] percpu/module resevation: change resevation size iff X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f44f1d5f-67b4-6ffd-80c1-28c48828f85b@scalemp.com>
Date:   Mon, 18 Mar 2019 10:18:48 +0200
From:   Eial Czerwacki <eial@...lemp.com>
To:     paulmck@...ux.ibm.com
Cc:     Tejun Heo <tj@...nel.org>, Barret Rhoden <brho@...gle.com>,
        Christopher Lameter <cl@...ux.com>,
        Dennis Zhou <dennis@...nel.org>, linux-kernel@...r.kernel.org,
        Shai Fultheim <shai@...lemp.com>, Oren Twaig <oren@...lemp.com>
Subject: Re: [PATCH] percpu/module resevation: change resevation size iff
 X86_VSMP is set

Greetings Paul,

On 3/15/19 12:19 AM, Paul E. McKenney wrote:
> On Thu, Mar 14, 2019 at 10:36:19AM -0700, Tejun Heo wrote:
>> On Wed, Mar 13, 2019 at 04:11:55PM -0700, Paul E. McKenney wrote:
>>> commit 34f67df09cc0c6bf082a7cfca435373caeeb8d82
>>> Author: Paul E. McKenney <paulmck@...ux.ibm.com>
>>> Date:   Wed Mar 13 16:06:22 2019 -0700
>>>
>>>     srcu: Forbid DEFINE{,_STATIC}_SRCU() from modules
>>>     
>>>     Adding DEFINE_SRCU() or DEFINE_STATIC_SRCU() to a loadable module
>>>     requires that the size of the reserved region be increased, which is
>>>     not something we want to be doing all that often.  Instead, loadable
>>>     modules should define an srcu_struct and invoke init_srcu_struct()
>>>     from their module_init function and cleanup_srcu_struct() from their
>>>     module_exit function.  Note that modules using call_srcu() will also
>>>     need to invoke srcu_barrier() from their module_exit function.
>>>     
>>>     This commit enforces this advice by refusing to define DEFINE_SRCU()
>>>     and DEFINE_STATIC_SRCU() within loadable modules.
>>>     
>>>     Suggested-by: Barret Rhoden <brho@...gle.com>
>>>     Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
>>
>> Looks-great-to-me-by: Tejun Heo <tj@...nel.org>
> 
> Applied.  ;-)
> 
> 							Thanx, Paul
> 
>> Thanks. :)
>>
>> -- 
>> tejun
>>
> 
> 

when can this patch be found in the kernel mainline git repo? I'd like
to test and see if the patch that started this mail thread still occurs.

Thanks,

Eial.