linux-kernel - Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <891.1554890512@warthog.procyon.org.uk>
Date:   Wed, 10 Apr 2019 11:01:52 +0100
From:   David Howells <dhowells@...hat.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk,
        devel@...verdev.osuosl.org, Todd Kjos <tkjos@...roid.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Arve Hjønnevåg <arve@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Martijn Coenen <maco@...roid.com>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API

Dan Carpenter <dan.carpenter@...cle.com> wrote:

> > +		struct ipc_namespace *ipc_ns = fc->s_fs_info;
> > +		put_ipc_ns(ipc_ns);
> 
> I feel like put_ipc_ns(info->ipc_ns) would be more readable.

Not so much more readable as more correct.

David