linux-kernel - Re: [PATCH] ipmi: avoid atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190415164022.GA32090@infradead.org>
Date:   Mon, 15 Apr 2019 09:40:22 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Corey Minyard <minyard@....org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipmi: avoid atomic_inc in exit function

On Mon, Apr 15, 2019 at 05:55:00PM +0200, Arnd Bergmann wrote:
> This causes a link failure on ARM in certain configurations,
> when we reference each atomic operation from .alt.smp.init in
> order to patch out atomics on non-SMP systems:
> 
> `.exit.text' referenced in section `.alt.smp.init' of drivers/char/ipmi/ipmi_msghandler.o: defined in discarded section `.exit.text' of drivers/char/ipmi/ipmi_msghandler.o
> 
> In this case, we can trivially replace the atomic_inc() with
> an atomic_set() that has the same effect and does not require
> a fixup.

I'd rather fіx the arm section management.  Using atomic in exit
routines is perfectly valid, and it would seem odd to forbid it.