linux-kernel - RE: [PATCH -next] ocxl: Fix return value check in afu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 May 2019 14:46:46 +1000
From:   "Alastair D'Silva" <alastair@...ilva.org>
To:     "'Wei Yongjun'" <weiyongjun1@...wei.com>,
        "'Frederic Barrat'" <fbarrat@...ux.ibm.com>,
        "'Andrew Donnellan'" <ajd@...ux.ibm.com>,
        "'Arnd Bergmann'" <arnd@...db.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>
Cc:     <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH -next] ocxl: Fix return value check in afu_ioctl()

> -----Original Message-----
> From: Wei Yongjun <weiyongjun1@...wei.com>
> Sent: Saturday, 4 May 2019 5:05 PM
> To: Frederic Barrat <fbarrat@...ux.ibm.com>; Andrew Donnellan
> <ajd@...ux.ibm.com>; Arnd Bergmann <arnd@...db.de>; Greg Kroah-
> Hartman <gregkh@...uxfoundation.org>; Alastair D'Silva <alastair@d-
> silva.org>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; linuxppc-
> dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org
> Subject: [PATCH -next] ocxl: Fix return value check in afu_ioctl()
> 
> In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
> 
> This issue was detected by using the Coccinelle software.
> 
> Fixes: 060146614643 ("ocxl: move event_fd handling to frontend")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/misc/ocxl/file.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index
> 8aa22893ed76..2870c25da166 100644
> --- a/drivers/misc/ocxl/file.c
> +++ b/drivers/misc/ocxl/file.c
> @@ -257,8 +257,8 @@ static long afu_ioctl(struct file *file, unsigned int
cmd,
>  			return -EINVAL;
>  		irq_id = ocxl_irq_offset_to_id(ctx, irq_fd.irq_offset);
>  		ev_ctx = eventfd_ctx_fdget(irq_fd.eventfd);
> -		if (!ev_ctx)
> -			return -EFAULT;
> +		if (IS_ERR(ev_ctx))
> +			return PTR_ERR(ev_ctx);
>  		rc = ocxl_irq_set_handler(ctx, irq_id, irq_handler,
irq_free,
> ev_ctx);
>  		break;

LGTM

Acked-by: Alastair D'Silva <alastair@...ilva.org>

-- 
Alastair D'Silva           mob: 0423 762 819
skype: alastair_dsilva     msn: alastair@...ilva.org
blog: http://alastair.d-silva.org    Twitter: @EvilDeece