linux-kernel - Re: Help with reviewing dosfstools patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614190803.2wg3gky5gypge6xp@pali>
Date:   Fri, 14 Jun 2019 21:08:03 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>,
        util-linux@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Help with reviewing dosfstools patches

On Friday 14 June 2019 07:30:52 Christoph Hellwig wrote:
> On Fri, Jun 14, 2019 at 04:25:34PM +0200, Pali Rohár wrote:
> > > Does the project already have a maillist ?
> > 
> > No, there is no mailing list. Basically whole development is on github
> > via github pull requests where are also put review comments and where is
> > also whole discussion, including bug reports.
> 
> That could explain why it is lacking qualified reviewers..

That is not my decision. Probably current maintainer of dosfstools like
it. But nowadays do not have much more time and gave me commit access.

Main benefit of github pull requests is that every one pull request
patch is automatically compiled and tested on i686, x86_64, x32, arm
and big endian powerpc systems via Travis CI. So author and also
reviewers/people with commit access immediately know if proposed change
could break something.

I like automated testing on more platforms, because lot of people either
do not know or do not have access to different systems just for testing.
And this can show possible problems...

Setting up a new mailing list, configuring some testing server, copying
existing patches from github to list, etc... is just tons of work for
which I basically do not have a time. Therefore I asked for help to
review existing stuff with minimal technical time setup.

I understand that it is not ideal for everybody, but for current
contributors it is probably better. I have already reviewed and merged
more patches, just those which are mine are left open, so more eyes can
look at them.

If you or somebody else have time and want to improve dosfstools
project, I'm not against it...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)