[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190618171453.GO5316@sirena.org.uk>
Date: Tue, 18 Jun 2019 18:14:53 +0100
From: Mark Brown <broonie@...nel.org>
To: Dmitry Osipenko <digetx@...il.com>
Cc: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Peter De Schrijver <pdeschrijver@...dia.com>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/8] soc/tegra: regulators: Add regulators coupler for
Tegra20
On Tue, Jun 18, 2019 at 07:52:06PM +0300, Dmitry Osipenko wrote:
> 17.06.2019 18:46, Mark Brown пишет:
> >> +// SPDX-License-Identifier: GPL-2.0+
> >> +/*
> >> + * Voltage regulators coupling resolver for NVIDIA Tegra20
> >> + *
> >> + * Copyright (C) 2019 GRATE-DRIVER project
> > Please make the entire comment a C++ one so things look more
> > intentional.
> This is actually a correct SPDX comment style for the source files, accordingly to
> checkpatch. While the C++ style should be used for header files only. I'm not
> following the SPDX effort much, don't know from where these SPDX-style rules are
> coming from.
The SPDX bit is fine, what I'm saying is make the rest of the comment
also be a C++ comment.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists