linux-kernel - Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c169739-febb-12a9-0fa1-d5da053ded67@st.com>
Date:   Fri, 21 Jun 2019 14:01:31 +0000
From:   Yannick FERTRE <yannick.fertre@...com>
To:     Emil Velikov <emil.l.velikov@...il.com>
CC:     Philippe CORNU <philippe.cornu@...com>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        "David Airlie" <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "ML dri-devel" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        LAKML <linux-arm-kernel@...ts.infradead.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume

Hi Emil,

The msm driver tests the return value & set state to NULL if no error is 
detected.

the ltdc driver tests the return value & force to suspend if an error is 
detected.

It's not exactly the same.

Best regards


-- 
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division

On 6/20/19 7:12 PM, Emil Velikov wrote:
> Hi Yannick,
>
> On Mon, 17 Jun 2019 at 08:18, Yannick Fertré <yannick.fertre@...com> wrote:
>
>> @@ -155,15 +154,17 @@ static __maybe_unused int drv_resume(struct device *dev)
>>          struct ltdc_device *ldev = ddev->dev_private;
>>          int ret;
>>
>> +       if (WARN_ON(!ldev->suspend_state))
>> +               return -ENOENT;
>> +
>>          pm_runtime_force_resume(dev);
>>          ret = drm_atomic_helper_resume(ddev, ldev->suspend_state);
>> -       if (ret) {
>> +       if (ret)
> Hmm the msm driver uses !ret here. Suspecting that you want the same,
> although I haven't checked in detail.
>
> HTH
> -Emil
-- 
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division