[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190626212213.GD101255@gmail.com>
Date: Wed, 26 Jun 2019 23:22:13 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
Peter Zijlstra <peterz@...radead.org>,
Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
Ashok Raj <ashok.raj@...el.com>,
Andi Kleen <andi.kleen@...el.com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
Stephane Eranian <eranian@...gle.com>,
Ravi Shankar <ravi.v.shankar@...el.com>
Subject: Re: [patch 00/29] x86/hpet: Cleanup the channel management
* Thomas Gleixner <tglx@...utronix.de> wrote:
> When reviewing the HPET NMI watchdog series, I stared into the HPET code
> and the proposed changes. The latter try to add yet another layer of duct
> tape and ifdeffery to the existing maze. No, thanks.
>
> The following series cleans up the channel management and consolidates all
> state storage into a single place instead of 3 different ad hoc allocated
> places which carry redundant information and make the code hard to follow.
>
> The reservation of a HPET channel for a NMI watchdog becomes a few lines of
> code after that series and just fits naturaly into that scheme without glue
> and more extra storage and ifdeffery.
>
> For your conveniance the series is also available from git:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git WIP.x86/hpet
>
> Thanks,
>
> tglx
>
> 8<---------------------
> include/asm/hpet.h | 7
> kernel/apic/msi.c | 4
> kernel/hpet.c | 937 +++++++++++++++++++++++------------------------------
> 3 files changed, 428 insertions(+), 520 deletions(-)
Modulo the minor nits I just posted, all the other patches (not written
by me) are looking good:
Reviewed-by: Ingo Molnar <mingo@...nel.org>
Thanks,
Ingo
Powered by blists - more mailing lists