linux-kernel - Re: [patch 26/29] x86/hpet: Consolidate clockevent functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1906280041160.32342@nanos.tec.linutronix.de>
Date:   Fri, 28 Jun 2019 00:44:38 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Ingo Molnar <mingo@...nel.org>
cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Andi Kleen <andi.kleen@...el.com>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
        Stephane Eranian <eranian@...gle.com>,
        Ravi Shankar <ravi.v.shankar@...el.com>
Subject: Re: [patch 26/29] x86/hpet: Consolidate clockevent functions

On Wed, 26 Jun 2019, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@...utronix.de> wrote:
> > -	evt->set_state_shutdown = hpet_msi_shutdown;
> > -	evt->set_state_oneshot = hpet_msi_set_oneshot;
> > -	evt->tick_resume = hpet_msi_resume;
> > -	evt->set_next_event = hpet_msi_next_event;
> > +	evt->set_state_shutdown = hpet_clkevt_shutdown;
> > +	evt->set_state_oneshot = hpet_clkevt_set_oneshot;
> > +	evt->set_next_event = hpet_clkevt_set_next_event;
> > +	evt->tick_resume = hpet_clkevt_msi_resume;
> >  	evt->cpumask = cpumask_of(hc->cpu);
> 
> My compulsive-obsessive half really wants this to look like:
> 
> > +	evt->set_state_shutdown	= hpet_clkevt_shutdown;
> > +	evt->set_state_oneshot	= hpet_clkevt_set_oneshot;
> > +	evt->set_next_event	= hpet_clkevt_set_next_event;
> > +	evt->tick_resume	= hpet_clkevt_msi_resume;
> >  	evt->cpumask		= cpumask_of(hc->cpu);

Just to remove all of that in the next patch again, which then has the
proper aligned thing to make you happy :)

> Also, maybe harmonize the callback names with the local function names, 
> like hpet_clkevt_set_next_event() already does and 
> hpet_clkevt_set_oneshot() almost does:
> 
>  s/hpet_clkevt_shutdown
>   /hpet_clkevt_set_state_shutdown
> 
>  s/hpet_clkevt_set_oneshot
>   /hpet_clkevt_set_state_oneshot
> 
>  s/hpet_clkevt_msi_resume
>   /hpet_clkevt_tick_resume
> 
> ... unless the name variations have some hidden purpose and meaning?

Historical but we want to preserve some of the old stuff for sentimental
reasons.

Thanks,

	tglx