linux-kernel - Re: [PATCH 1/7] crypto: ux500: Use spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1907261409540.1791@nanos.tec.linutronix.de>
Date:   Fri, 26 Jul 2019 14:10:05 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 1/7] crypto: ux500: Use spinlock_t instead of struct
 spinlock

On Thu, 4 Jul 2019, Sebastian Andrzej Siewior wrote:

Polite reminder...

> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
> 
> Use spinlock_t for spinlock's definition.
> 
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-crypto@...r.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/crypto/ux500/cryp/cryp.h     | 4 ++--
>  drivers/crypto/ux500/hash/hash_alg.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/ux500/cryp/cryp.h b/drivers/crypto/ux500/cryp/cryp.h
> index bd89504e81678..8da7f87b339b4 100644
> --- a/drivers/crypto/ux500/cryp/cryp.h
> +++ b/drivers/crypto/ux500/cryp/cryp.h
> @@ -241,12 +241,12 @@ struct cryp_device_data {
>  	struct clk *clk;
>  	struct regulator *pwr_regulator;
>  	int power_status;
> -	struct spinlock ctx_lock;
> +	spinlock_t ctx_lock;
>  	struct cryp_ctx *current_ctx;
>  	struct klist_node list_node;
>  	struct cryp_dma dma;
>  	bool power_state;
> -	struct spinlock power_state_spinlock;
> +	spinlock_t power_state_spinlock;
>  	bool restore_dev_ctx;
>  };
>  
> diff --git a/drivers/crypto/ux500/hash/hash_alg.h b/drivers/crypto/ux500/hash/hash_alg.h
> index ab2bd00c1c365..7c9bcc15125ff 100644
> --- a/drivers/crypto/ux500/hash/hash_alg.h
> +++ b/drivers/crypto/ux500/hash/hash_alg.h
> @@ -366,10 +366,10 @@ struct hash_device_data {
>  	phys_addr_t             phybase;
>  	struct klist_node	list_node;
>  	struct device		*dev;
> -	struct spinlock		ctx_lock;
> +	spinlock_t		ctx_lock;
>  	struct hash_ctx		*current_ctx;
>  	bool			power_state;
> -	struct spinlock		power_state_lock;
> +	spinlock_t		power_state_lock;
>  	struct regulator	*regulator;
>  	struct clk		*clk;
>  	bool			restore_dev_state;
> -- 
> 2.20.1
> 
>