linux-kernel - Re: [PATCH 3/5] drm/imx: Add initial support for DCSS on iMX8MQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909240057.ImIOgwqi%lkp@intel.com>
Date:   Tue, 24 Sep 2019 00:24:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Laurentiu Palcu <laurentiu.palcu@....com>
Cc:     kbuild-all@...org, Philipp Zabel <p.zabel@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>, agx@...xcpu.org,
        l.stach@...gutronix.de, Laurentiu Palcu <laurentiu.palcu@....com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/5] drm/imx: Add initial support for DCSS on iMX8MQ

Hi Laurentiu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Laurentiu-Palcu/Add-support-for-iMX8MQ-Display-Controller-Subsystem/20190923-230115
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/imx/dcss/dcss-blkctl.c: In function 'dcss_blkctl_init':
>> drivers/gpu/drm/imx/dcss/dcss-blkctl.c:50:58: error: 'SZ_4K' undeclared (first use in this function)
     blkctl->base_reg = devm_ioremap(dcss->dev, blkctl_base, SZ_4K);
                                                             ^~~~~
   drivers/gpu/drm/imx/dcss/dcss-blkctl.c:50:58: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/gpu/drm/imx/dcss/dcss-dtg.c: In function 'dcss_dtg_init':
>> drivers/gpu/drm/imx/dcss/dcss-dtg.c:174:52: error: 'SZ_4K' undeclared (first use in this function)
     dtg->base_reg = devm_ioremap(dcss->dev, dtg_base, SZ_4K);
                                                       ^~~~~
   drivers/gpu/drm/imx/dcss/dcss-dtg.c:174:52: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/gpu/drm/imx/dcss/dcss-ss.c: In function 'dcss_ss_init':
>> drivers/gpu/drm/imx/dcss/dcss-ss.c:93:50: error: 'SZ_4K' undeclared (first use in this function)
     ss->base_reg = devm_ioremap(dcss->dev, ss_base, SZ_4K);
                                                     ^~~~~
   drivers/gpu/drm/imx/dcss/dcss-ss.c:93:50: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/gpu/drm/imx/dcss/dcss-dpr.c: In function 'dcss_dpr_ch_init_all':
>> drivers/gpu/drm/imx/dcss/dcss-dpr.c:125:55: error: 'SZ_4K' undeclared (first use in this function)
      ch->base_reg = devm_ioremap(dpr->dev, ch->base_ofs, SZ_4K);
                                                          ^~~~~
   drivers/gpu/drm/imx/dcss/dcss-dpr.c:125:55: note: each undeclared identifier is reported only once for each function it appears in
--
   drivers/gpu/drm/imx/dcss/dcss-scaler.c: In function 'dcss_scaler_ch_init_all':
>> drivers/gpu/drm/imx/dcss/dcss-scaler.c:287:55: error: 'SZ_4K' undeclared (first use in this function)
      ch->base_reg = devm_ioremap(scl->dev, ch->base_ofs, SZ_4K);
                                                          ^~~~~
   drivers/gpu/drm/imx/dcss/dcss-scaler.c:287:55: note: each undeclared identifier is reported only once for each function it appears in

vim +/SZ_4K +50 drivers/gpu/drm/imx/dcss/dcss-blkctl.c

    41	
    42	int dcss_blkctl_init(struct dcss_dev *dcss, unsigned long blkctl_base)
    43	{
    44		struct dcss_blkctl *blkctl;
    45	
    46		blkctl = devm_kzalloc(dcss->dev, sizeof(*blkctl), GFP_KERNEL);
    47		if (!blkctl)
    48			return -ENOMEM;
    49	
  > 50		blkctl->base_reg = devm_ioremap(dcss->dev, blkctl_base, SZ_4K);
    51		if (!blkctl->base_reg) {
    52			dev_err(dcss->dev, "unable to remap BLK CTRL base\n");
    53			devm_kfree(dcss->dev, blkctl);
    54			return -ENOMEM;
    55		}
    56	
    57		dcss->blkctl = blkctl;
    58		blkctl->dev = dcss->dev;
    59		blkctl->hdmi_output = dcss->hdmi_output;
    60	
    61		dcss_blkctl_cfg(blkctl);
    62	
    63		return 0;
    64	}
    65	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50075 bytes)