linux-kernel - Re: [PATCH v2 0/3] s390/livepatch: Implement reliable stack tracing for the consistency model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 17:34:50 +0100
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     gor@...ux.ibm.com, borntraeger@...ibm.com, jpoimboe@...hat.com,
        joe.lawrence@...hat.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, jikos@...nel.org, pmladek@...e.com,
        nstange@...e.de, live-patching@...r.kernel.org
Subject: Re: [PATCH v2 0/3] s390/livepatch: Implement reliable stack tracing
 for the consistency model

On Tue, Oct 29, 2019 at 03:39:01PM +0100, Miroslav Benes wrote:
> - I tried to use the existing infrastructure as much as possible with
>   one exception. I kept unwind_next_frame_reliable() next to the
>   ordinary unwind_next_frame(). I did not come up with a nice solution
>   how to integrate it. The reliable unwinding is executed on a task
>   stack only, which leads to a nice simplification. My integration
>   attempts only obfuscated the existing unwind_next_frame() which is
>   already not easy to read. Ideas are definitely welcome.

Ah, now I see. So patch 2 seems to be leftover(?). Could you just send
how the result would look like?

I'd really like to have only one function, since some of the sanity
checks you added also make sense for what we already have - so code
would diverge from the beginning.