linux-kernel - Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it declares is never used.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Nov 2019 11:51:06 -0400
From:   "J. Bruce Fields" <bfields@...hat.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Chuck Lever <chuck.lever@...cle.com>,
        Mao Wenan <maowenan@...wei.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Dros Adamson <dros@...marydata.com>,
        jeff.layton@...marydata.com, richard.sharpe@...marydata.com,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] nfsd: Drop LIST_HEAD where the variable it
 declares is never used.

On Fri, Nov 01, 2019 at 05:49:21PM +0300, Dan Carpenter wrote:
> On Fri, Nov 01, 2019 at 09:36:27AM -0400, Chuck Lever wrote:
> > > On Nov 1, 2019, at 7:40 AM, Mao Wenan <maowenan@...wei.com> wrote:
> > > 
> > > The declarations were introduced with the file, but the declared
> > > variables were not used.
> > > 
> > > Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd")

Thanks, applying for 5.5.

> > I'm not sure a Fixes: tag is necessary here? 65294c1f2c5e
> > works fine without this change, and it's not something we
> > would need to backport into stable kernels.
> > 
> > This is more of a clean up patch.
> > 
> 
> Fixes is not really related to backports or stable.  I would agree that
> this isn't a bug but just a cleanup, but the problem is that other
> people want Fixes tags for everything...
> 
> Yesterday I sent a cleanup patch and I almost put the Fixes tag under
> the --- cut off but in the end I just deleted it...  It's hard to know
> what the right thing is.

It doesn't have a stable cc and it's pretty obvious cleanup, so I guess
there's no harm in it.

I could go either way.  But I'll leave the patch as is unless someone
comes up with a clear policy.

--b.