linux-kernel - Re: [PATCH v2 3/3] clk: qcom: clk-rpmh: Add support for RPMHCC for SC7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191107211353.C15F62077C@mail.kernel.org>
Date:   Thu, 07 Nov 2019 13:13:53 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Taniya Das <tdas@...eaurora.org>
Cc:     David Brown <david.brown@...aro.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh@...nel.org, robh+dt@...nel.org,
        Taniya Das <tdas@...eaurora.org>
Subject: Re: [PATCH v2 3/3] clk: qcom: clk-rpmh: Add support for RPMHCC for SC7180

Quoting Taniya Das (2019-10-29 10:48:19)
> Add support for clock RPMh driver to vote for ARC and VRM managed
> clock resources.
> 
> Signed-off-by: Taniya Das <tdas@...eaurora.org>
> ---
>  drivers/clk/qcom/clk-rpmh.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 20d4258..3f3e08b 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -391,6 +391,24 @@ static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
>         .num_clks = ARRAY_SIZE(sm8150_rpmh_clocks),
>  };
> 
> +static struct clk_hw *sc7180_rpmh_clocks[] = {

I don't think we need to duplicate this array either, unless somehow
this driver is running on two different SoCs which seems highly
unlikely.

> +       [RPMH_CXO_CLK]          = &sdm845_bi_tcxo.hw,
> +       [RPMH_CXO_CLK_A]        = &sdm845_bi_tcxo_ao.hw,
> +       [RPMH_LN_BB_CLK2]       = &sdm845_ln_bb_clk2.hw,
> +       [RPMH_LN_BB_CLK2_A]     = &sdm845_ln_bb_clk2_ao.hw,
> +       [RPMH_LN_BB_CLK3]       = &sdm845_ln_bb_clk3.hw,
> +       [RPMH_LN_BB_CLK3_A]     = &sdm845_ln_bb_clk3_ao.hw,
> +       [RPMH_RF_CLK1]          = &sdm845_rf_clk1.hw,
> +       [RPMH_RF_CLK1_A]        = &sdm845_rf_clk1_ao.hw,
> +       [RPMH_RF_CLK2]          = &sdm845_rf_clk2.hw,
> +       [RPMH_RF_CLK2_A]        = &sdm845_rf_clk2_ao.hw,
> +};
> +
> +static const struct clk_rpmh_desc clk_rpmh_sc7180 = {
> +       .clks = sc7180_rpmh_clocks,
> +       .num_clks = ARRAY_SIZE(sc7180_rpmh_clocks),
> +};
> +
>  static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec,
>                                          void *data)
>  {
> @@ -471,6 +489,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
>  static const struct of_device_id clk_rpmh_match_table[] = {
>         { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
>         { .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150},
> +       { .compatible = "qcom,sc7180-rpmh-clk", .data = &clk_rpmh_sc7180},
>         { }
>  };
>  MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);