[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2019 12:09:44 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-serial@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
Hyunki Koo <kkoos00@...er.com>,
HYUN-KI KOO <hyunki00.koo@...sung.com>,
Shinbeom Choi <sbeom.choi@...sung.com>,
Jiri Slaby <jslaby@...e.com>,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/10] tty: serial: samsung_tty: fix blank line
checkpatch warning
On Tue, Dec 10, 2019 at 04:13:45PM +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 10, 2019 at 03:37:06PM +0100, Greg Kroah-Hartman wrote:
> > checkpatch is giving a bunch of:
> > WARNING: Missing a blank line after declarations
> > messages on this file, so fix up all instances of that issue.
>
> I would prefer to squash it with previous. These are not bugs, just
> minor coding style violations so there is no point to split it per
> patch. Too much churn.
For coding style fixes, in staging, I require "one type of change per
patch" otherwise big "fix all the coding style issues" patches are
impossible to review.
Breaking it up into tiny pieces makes it easy/trivial to review, which
makes it easier for maintainers, which is the key here. There is no
"churn".
thanks,
greg k-h
Powered by blists - more mailing lists