linux-kernel - Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Feb 2020 15:52:32 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [[PATCH staging] 3/7] staging: wfx: fix init/remove vs IRQ race

On Tue, Feb 11, 2020 at 11:39:31AM +0100, Michał Mirosław wrote:
> On Tue, Feb 11, 2020 at 12:23:54PM +0300, Dan Carpenter wrote:
> > On Tue, Feb 11, 2020 at 09:46:54AM +0100, Michał Mirosław wrote:
> > > @@ -234,8 +234,8 @@ static void wfx_sdio_remove(struct sdio_func *func)
> > >  	struct wfx_sdio_priv *bus = sdio_get_drvdata(func);
> > >  
> > >  	wfx_release(bus->core);
> > > -	wfx_free_common(bus->core);
> > >  	wfx_sdio_irq_unsubscribe(bus);
> >         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > 
> > This calls sdio_release_host(func);
> > 
> > > +	wfx_free_common(bus->core);
> > >  	sdio_claim_host(func);
> > >  	sdio_disable_func(func);
> > >  	sdio_release_host(func);
> >         ^^^^^^^^^^^^^^^^^^^^^^^^
> > so is this a double free?
> 
> This is paired with sdio_claim_host() just above.

Ah...  I misread wfx_sdio_irq_unsubscribe(), sorry.

regards,
dan carpenter